Skip to content

[IMP] Appraisals: Update main doc #13141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

larm-odoo
Copy link
Contributor

@larm-odoo larm-odoo commented Apr 29, 2025

Configuration and overview content is now on individual appraisal pages (#13230, #13373, #13244). This PR removes the redundant overview page.

@larm-odoo larm-odoo added the 2 label Apr 29, 2025
@larm-odoo larm-odoo self-assigned this Apr 29, 2025
@robodoo
Copy link
Collaborator

robodoo commented Apr 29, 2025

Pull request status dashboard

@larm-odoo larm-odoo marked this pull request as draft April 29, 2025 22:19
@larm-odoo larm-odoo force-pushed the 18.0-appraisals-update-config-larm branch from 1020b5b to 0d50b90 Compare April 30, 2025 21:24
@larm-odoo larm-odoo marked this pull request as ready for review April 30, 2025 21:24
@larm-odoo larm-odoo added 3 and removed 2 labels Apr 30, 2025
@C3POdoo C3POdoo requested a review from a team April 30, 2025 21:26
@larm-odoo
Copy link
Contributor Author

Hi @justinmallette - this is ready for a peer review!

Copy link
Contributor

@justinmallette justinmallette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small things from me!

@larm-odoo larm-odoo force-pushed the 18.0-appraisals-update-config-larm branch from 0d50b90 to ea35554 Compare May 1, 2025 17:13
@larm-odoo larm-odoo requested a review from a team May 1, 2025 17:13
@larm-odoo
Copy link
Contributor Author

Hi @Felicious - this is ready for a final review!

@@ -16,121 +15,119 @@ promotions, and other benefits.
Regular appraisals are good for both the employees and the company, since they can accurately
measure performance based on company goals, and show employees where they need to improve.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to take some time to provide a totally optional rewrite to the introduction. The original has all the key features and delivers the value proposition of the Appraisal app. It's already strong!

I've drafted a more concise version and walk you through what changed and why I'm changing it, so you understand my reasoning, and hopefully this guides you to be consistently concise in your documentation 😊

Proposed rewrite

The Appraisals app provides a structured, repeatable way to review performance and set goals. Managers schedule reviews, employees complete self-assessments, and both sides record feedback in one place. Custom templates, rating scales, and 360° feedback keep each review aligned with company objectives and highlight concrete next steps—information managers can later use for raises, promotions, or training plans.

Why this version works better

Goal Original Rewrite Rationale
Lead with value Opens by stating the app “is used to evaluate employee performance.” Opens with the outcome: “a structured, repeatable way to review performance and set goals.” Hooks readers with what they gain first, not the mechanics.
Keep it concise Several sentences repeat why appraisals are useful. Consolidates benefits into two focused sentences. Reduces reading time while preserving meaning.
Avoid generic phrasing “Good for both the employees and the company.” Lists specific results: feedback, goals, raises, promotions, training plans. Concrete examples feel more actionable than generic praise.

Your draft contained all the right ingredients—I just repackaged them so readers can grasp the value faster. Feel free to use or adapt this rewrite, and let me know if any part of the reasoning isn’t clear. Happy to chat or pair on edits.

Great work getting the substance down; these small tweaks push it over the finish line. 🚀

@larm-odoo larm-odoo force-pushed the 18.0-appraisals-update-config-larm branch from ea35554 to 893c3c4 Compare May 28, 2025 14:04
@larm-odoo larm-odoo requested a review from Felicious May 28, 2025 14:05
@larm-odoo
Copy link
Contributor Author

Hi @Felicious - just cleaning up my open PR's. This was on hold while the entire Appraisals folder of docs was updated and added to. So now, I just need to remove the redundant info that is on other docs. Should be a super simple review! =)

@larm-odoo larm-odoo added the 2 label May 28, 2025
Copy link
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @larm-odoo ! I added a comment to change the page title to "Appraisals" (:

A couple random things unrelated to the writing:

  1. Since we moved the content of this page out in other PRs, I think we can "demote" this PR from a 3 point rewrite to a 2 point removal. So can you change the points to reflect that?
  2. Let's modify the PR description to reflect the changes that are reflected in this PR. How about changing the PR description to something like:

Configuration and overview content is now on individual appraisal pages (#13230, #13373, #13244). This PR removes the redundant overview page.

@larm-odoo larm-odoo removed the 3 label May 28, 2025
@larm-odoo larm-odoo force-pushed the 18.0-appraisals-update-config-larm branch from 893c3c4 to 14460d5 Compare May 29, 2025 13:35
@larm-odoo
Copy link
Contributor Author

Hi @samueljlieber - this should be a quick tech review (I hope!) =)

Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @larm-odoo, looks good– before merging please remove the following unused image files:

  • content/applications/hr/appraisals/evaluation-scale.png
  • content/applications/hr/appraisals/survey-list.png

Thank you!
..
@robodoo delegate=larm-odoo

@larm-odoo
Copy link
Contributor Author

@robodoo r+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants